vBCommbull - Copyright in emails but content NOT rewritten

Odd... mine doesn't appear to be vBSEO'ing the urls in the text-only version. :(

Same here after I updated the hack.

Perhaps Joe Ward can provide a solution.

Originally Posted by kall

Odd... mine doesn't appear to be vBSEO'ing the urls in the text-only version. :(

1. Modify the following...

FIND:

define('VBSEO_REWRITE_TEXTURLS', 1);

REPLACE WITH:

$GLOBALS['VBSEO_REWRITE_TEXTURLS'] = 1;

2. Step 4 is not required, the changes made should be reverted.

Let me know if it helps..

Both times, yes?

That did the trick.

Originally Posted by DerTobi75

No, there are only and once: vbseo global hook and vbseo email send!

I too have the triple copyright issue now.

Hi,

a new version of vBcommbull uses vbmail() function to send emails instead of direct mail() calls. In this case the content of bulletin is rewritten once for preview and then for every email sent (inside of vbmail() function).

Please apply the following modification: in admincp/commbull.php file find vbmail(..) function calls, comment them out (add "//" at the beginning of line) and uncomment the previous line with mail() function call.

Namely,
FIND:

//mail($user[email],$html_subject,$HTML_mailbody,$htmlEmailHeader);
vbmail($user[email],$html_subject,$HTML_mailbody,false,$vbulletin->options['webmasteremail']);

REPLACE WITH:

mail($user[email],$html_subject,$HTML_mailbody,$htmlEmailHeader);
//vbmail($user[email],$html_subject,$HTML_mailbody,false,$vbulletin->options['webmasteremail']);

FIND:

mail($user[email],$subject,$mailbody,"From: \"$bbtitle Mailer\"<$webmasteremail>");
//vbmail($user[email],$subject,$mailbody,false,$vbulletin->options['webmasteremail']);

REPLACE WITH:

mail($user[email],$subject,$mailbody,"From: \"$bbtitle Mailer\"<$webmasteremail>");
//vbmail($user[email],$subject,$mailbody,false,$vbulletin->options['webmasteremail']);

That should solve the multiple copyrights problem and should improve the performance significantly.

Please let me know if that helps

Strange.. I now only get two copyrights.

One appears on the preview, I assume the other is added in generation?

I notice now that your second find/replace is just the find part repeated.. I will try again.

i wish someone would have pointed me to this earlier. I will be putting this directly into the code for all future versions of commbull. If there are any other issues, i would be happy to work directly with vbseo on solving these issues ... cheers.