Results 1 to 11 of 11

Base URL

This is a discussion on Base URL within the Troubleshooting forums, part of the vBSEO SEO Plugin category; I am running vBulletin 3.8.2 with vBSEO 3.3.0. I am adding some custom code to some files and to ensure ...

  1. #1
    Member Array
    Real Name
    Rich
    Join Date
    Oct 2005
    Location
    Massachusetts
    Posts
    44
    Liked
    0 times

    Base URL

    I am running vBulletin 3.8.2 with vBSEO 3.3.0. I am adding some custom code to some files and to ensure it was working I had to view the source code. I was surprised to see this:

    Code:
    <base href="http://www.#####.com/" /><!--[if IE]></base><![endif]-->
    That is the code within the pages code. I am pretty certain that the closing base element isn't doing much in IE since it is wrapped in the comment tags.

    I am not familiar with the IE conditional, but that simply doesn't look as if it is suppose to be in the code.

    When I disabled vbseo it no longer displayed, so it is being tossed in by this modification. If you want to truly confirm this, have a look at your source code in the forums. it is there also.

    Is that suppose to show or is it actually suppose to show this instead:

    <base href="http://www.#####.com/" /></base>

    (I blocked the URL because the site is in development and isn't "public" just yet.)

    This doesn't seem to be causing my site any problems. I am just posting it because it doesn't look right.

  2. #2
    vBSEO Staff Array Oleg Ignatiuk's Avatar
    Real Name
    Oleg Ignatiuk
    Join Date
    Jun 2005
    Location
    Belarus
    Posts
    25,818
    Liked
    192 times
    Hello,

    you can find a description in this thread: Internet explorer cannont open the internet site [thread] Operation Aborted
    Oleg Ignatiuk / Crawlability Inc.
    Security bulletin - Patch Level for all supported versions released

    Unveiling the NEW vBSEO Sitemap Generator 3.0. - available NOW for vBSEO Customers!


  3. #3
    Member Array
    Real Name
    Rich
    Join Date
    Oct 2005
    Location
    Massachusetts
    Posts
    44
    Liked
    0 times
    Perhaps I am not being clear enough in what I was trying to say. I just viewed this threads source code and I see this:

    Code:
     
    <base href="vBSEO - vBulletin SEO" /><!--[if IE]></base><![endif]-->
    I mean I can physically see that in the source code for the page output. Should we actually be seeing the if statement for IE? Shouldn't that be processed before the pages code is output?

  4. #4
    Senior Member Array Shadab's Avatar
    Real Name
    Shadab
    Join Date
    Oct 2007
    Location
    Bhopal
    Posts
    821
    Liked
    0 times
    Blog Entries
    12
    I mean I can physically see that in the source code for the page output. Should we actually be seeing the if statement for IE? Shouldn't that be processed before the pages code is output?
    Yes, it's perfectly fine.
    That conditional is meant to be processed by the 'browser'.

    See: CSS - Conditional comments

  5. #5
    Member Array
    Real Name
    Rich
    Join Date
    Oct 2005
    Location
    Massachusetts
    Posts
    44
    Liked
    0 times
    Excellent, that is all I was wondering. lol Thank you.

  6. #6
    Senior Member Array
    Real Name
    Brian
    Join Date
    Apr 2006
    Posts
    6,983
    Liked
    10 times
    Ie incorrectly handles the self-closing /> tag on the base element (basically ignores it)

    Thus, if ie, it gets a </base> otherwise, the self-close tag will work fine.

  7. #7
    Senior Member Array
    Real Name
    Marvin Hlavac
    Join Date
    Oct 2007
    Posts
    259
    Liked
    17 times
    If I wanted to remove the entire

    <base href="http://www.#####.com/" /></base>

    how would I do that? I don't see <base in any template. Would I need to edit a PHP file? Which one?

  8. #8
    vBSEO Staff Array Brian Cummiskey's Avatar
    Real Name
    Brian Cummiskey
    Join Date
    Jul 2009
    Location
    btwn NYC and Boston
    Posts
    12,789
    Liked
    675 times
    Blog Entries
    2
    This is required for vbseo to function properly.

    Anything using a virtual folder, like /groups/ will break with it removed.
    Brian Cummiskey / Crawlability Inc.
    Security bulletin - Patch Level for all supported versions released

    Unveiling the NEW vBSEO Sitemap Generator 3.0. - available NOW for vBSEO Customers!


  9. #9
    Senior Member Array
    Real Name
    Marvin Hlavac
    Join Date
    Oct 2007
    Posts
    259
    Liked
    17 times
    Thanks Brian. The removal of the line of code would likely not affect my forum, as I don't use Groups, nor most other vB features at all. Also, I've noticed that I see that line only in my forumdisplay pages. Some of the many modifications I've done in the past must have broke that feature / remove the code from the rest of the site long ago

    It's not a big deal, but if there was an easy way to remove the line of code from my forumdisplay pages, I would likely try to remove it to see if it brakes something.

  10. #10
    vBSEO Staff Array Brian Cummiskey's Avatar
    Real Name
    Brian Cummiskey
    Join Date
    Jul 2009
    Location
    btwn NYC and Boston
    Posts
    12,789
    Liked
    675 times
    Blog Entries
    2
    Do you use nested forums, like
    /forum1/thread23423/

    If so, anything in /threads/ will reference the wrong folder too.

    It is necessary if you use ANYTHING with hierarchy.
    Brian Cummiskey / Crawlability Inc.
    Security bulletin - Patch Level for all supported versions released

    Unveiling the NEW vBSEO Sitemap Generator 3.0. - available NOW for vBSEO Customers!


  11. #11
    Senior Member Array
    Real Name
    Marvin Hlavac
    Join Date
    Oct 2007
    Posts
    259
    Liked
    17 times
    I see. Thanks for the info. My thread URLs look like the following example (so I guess I'm OK):

    http://www.example.com/1234-my-thread-name

Similar Threads

  1. Base Href
    By Swissbob in forum General Discussion
    Replies: 15
    Last Post: 01-16-2011, 11:09 PM
  2. href base
    By John_The_Comingman in forum Deutsch
    Replies: 1
    Last Post: 06-15-2006, 02:45 PM
  3. Base href?
    By Ace Shattock in forum Bug Reporting
    Replies: 5
    Last Post: 08-11-2005, 07:43 PM

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •