vBulletin 3.x Why doesn't vBSEO include thread prefixes in URLs on forumhome?

[Keyser Soze]

I have enabled vbulletin's thread prefixes in my forum and I have also enabled the vBSEO-option to include those thread prefixes in the URLs. This is working on most places in my forum and the URLs look like this:
http://www.myforum.com/forumtitle/threadid-threadprefix-threadtitle.html

But on forumhome, the links to the latest threads in the subforums look like this:
http://www.myforum.com/forumname/threadid-threadtitle.html (=no prefix included)

What causes this difference and how can I enable urls including thread prefixes on forumhome?

[Oleg Ignatiuk]

Hello,

are you running the latest vBSEO version? (if not, can you try 3.5.0RC2?)

[Mert Gökçeimam]

Hello ,

I just tested and this works correct on my test installations. If you are receiving this error with RC2 please create a support ticket so we can check.

[Keyser Soze]

I am using the latest stable version vBSEO 3.3.2. I don't want to install beta-software on my forum. If this should not be a bug, then please move this thread to the troubleshooting-section.

[Keyser Soze]

I have tested a little bit more. The problem is not limited to the forumhome-page. The problem seems to be in the functions vbseo_thread_url_row_spec() and vbseo_thread_url_row(). Whenever these functions are called in the forumbits-templates, the thread prefix is missing in the url. But on all other sections of my forum (showthread, showpost etc) the thread prefixes in the urls are working fine.

[Keyser Soze]

Allright folks... I have installed a new and clean vbulletin 3.8.5 and a new and clean vBSEO 3.3.2 on 5 different servers with 5 very different server configurations and I can reproduce this behaviour described above on every single one of them. These servers have very different configurations from mysql 4-5, php from 5.2 - 5.3 running as mod_php, fastcgi etc, OS is Debian, Gentoo and others. And even on shared hosting servers the problem is the same.
And you want to tell me that everything is working fine on all your test installations? Please show me an example of a webserver running vbulletin and vbseo and that does not show this bug.

[Oleg Ignatiuk]

Please try to modify functions_vbseo.php file:
find:

foreach($threadcache as $tid => $tar)
{
$vbseo_gcache['thread'][$tar['threadid'] ? $tar['threadid'] : $tid] = $tar;
if($found_object_ids['thread_last'] && in_array($tar['threadid'], $found_object_ids['thread_last']))
$found_object_ids['user_names'][] = $tar['lastposter'];
}

replace with:

$threadcache_ids = array();
foreach($threadcache as $tid => $tar)
{
$tid = $tar['threadid'] ? $tar['threadid'] : $tid;
$vbseo_gcache['thread'][$tid] = $tar;
if($found_object_ids['thread_last'] && in_array($tar['threadid'], $found_object_ids['thread_last']))
$found_object_ids['user_names'][] = $tar['lastposter'];

if(!VBSEO_URL_THREAD_PREFIX || $vbseo_gcache['thread'][$id]['prefixid'])
$threadcache_ids[] = $tid;
}
$found_object_ids['thread_ids'] = array_diff($found_object_ids['thread_ids'], $threadcache_ids);

in functions_vbseo_vb.php file:
find:

if (isset($vbseo_gcache['thread'][$id])) continue;

replace with:

if (isset($vbseo_gcache['thread'][$id]))
{
if(!VBSEO_URL_THREAD_PREFIX || $vbseo_gcache['thread'][$id]['prefixid'])
continue;
}else

[Keyser Soze]

I have added these modifications and still can't see thread prefixes in the urls in the forumbits-sections.

[Keyser Soze]

Could it be that you forgot one line your first quote regarding functions_vbseo.php?
If I add your modifications, it would produce these two lines:

$found_object_ids['thread_ids'] = array_diff($found_object_ids['thread_ids'], $threadcache_ids); 
$found_object_ids['thread_ids'] = array_diff($found_object_ids['thread_ids'], array_keys($threadcache)); 

If I remove the second (almost duplicate) line and then it seems to work. Is that correct or did I get something wrong?

[Oleg Ignatiuk]

Sorry for delay, yes this is correct.