VBSEO is messing up certain URLs (it is affecting OpenX)

Hi,



I found a bug in VBSEO that need to be fixed ASAP.

The bug is always reproducible. The steps required to reproduce the bug are the following:

1. Assume that VBSEO is installed on a domain named www.somesite.com
   
   
2. Populate a PHP variable with an anchor like this:
   
   
   PHP Code:

   $anchor1 = <<<EOF
 <a href="http://www.somesite.com/openx/www/send/unc.php?oaparams=2__bannerid=15__zoneid=3__cb=5d73316f4f__maxdest=http://www.somesite.com/rp.php"
EOF; 

   and print the variable from a VB template (edit the template to include the variable $anchor1).
   
   
3. The final output page (after processing by VBSEO) is this:
   
   
   HTML Code:

   <a href="http://www.somesite.com/openx/www/send/unc.php?oaparams=http://www.somesite.com2__bannerid=15__zoneid=3__cb=5d73316f4f__maxdest=http://www.somesite.com/rp.php"

   Where VBSEO finds the first equal sign, it inserts the string "http://www.somesite.com/", in this particular case, this is happening after the string "oaparams";
   
   The expected output is this:
   
   HTML Code:

   <a href="http://www.somesite.com/openx/www/send/unc.php?oaparams=2__bannerid=15__zoneid=3__cb=5d73316f4f__maxdest=http://www.somesite.com/rp.php"

NOTE1:
This is happening only if the last part of the anchor contains a string that is EXACTLY as the domain name where VBSEO is installed. In other words, if you need to test this on www.yourdomain.com then replace www.somedomain.com in the anchor in both places (is appears twice).

For example, the following URL will not cause trouble:

HTML Code:

<a href="http://www.somesite.com/openx/www/send/unc.php?oaparams=http://www.somesite.com2__bannerid=15__zoneid=3__cb=5d73316f4f__maxdest=http://www.google.com/"

Look at the end of the anchor and notice that it ends in "http://www.google.com/" not in "http://www.somesite.com"

The above kinds of anchors are generated by OpenX. More precisely, users of OpenX will face this bug when they are creating ads to their own web site !!! This is happening only if the delivery method from OpenX is "Local mode". If they are using some other delivery options like the "Iframe" then they will not notice this bug because when an "iframe" is used, the code is not parsed by VBSEO !

Please fix this ASAP so that there will be no more issues with OpenX.


Regards,
Razvan

Please try to modify file:
FIND:

PHP Code:

if(strstr($dec_v,'http:') && strstr($dec_v,$vboptions['bburl2'])) 


REPLACE WITH:

PHP Code:

if(strstr($dec_v,'http:') && (substr($dec_v,strlen($vboptions['bburl2']))==$vboptions['bburl2'])) 


Originally Posted by Oleg Ignatiuk

Please try to modify file:
FIND:

PHP Code:

if(strstr($dec_v,'http:') && strstr($dec_v,$vboptions['bburl2'])) 


REPLACE WITH:

PHP Code:

if(strstr($dec_v,'http:') && (substr($dec_v,strlen($vboptions['bburl2']))==$vboptions['bburl2'])) 


Thank you: I tested and it is working. I found the code that you mentioned in the file "functions_vbseo.php".

Are you going to include this patch in the next minor version of VBSEO ?


Regards,
Razvan

Ye s, the fix is already been applied to vBSEO 3.2.5

An update: if you have OpenX installed inside of forums folder, it's recommended to create an .htaccess file in openx/ folder to avoid processing of "click" requests by vBSEO:

Code:

RewriteEngine off