vBSEO 3.3.2: vB (default) social bookmark rewrite

It seems vBSEO doesn't rewrite the URL if there's a space (%20) before {URL}

Example:

Code:

http://twitter.com/home?status={TITLE}%20-%20{URL}

Rewrites to

Code:

http://twitter.com/home?status=another+test+poll%20-%20http%3A%2F%2Fvampireacademy.net%2Fshowthread.php%3Ft%3D34

instead of

Code:

http://twitter.com/home?status=another+test+poll%20-%20http%3A%2F%2Fvampireacademy.net%2Fanother-test-poll%2F34%2F

Demo:
another test poll - Vampire Academy

Even though it's for vBSEO 3.3.2, would there be a temporary fix for this perhaps?

Hello,

I've flagged this for developer review.

I am not actually sure this is a bug Cor. Those variables are not designed to hold spaces.You should use the following format :

Code:

http://twitter.com/home?status=%title%-%url%

Hi Mert,

vBSEO's bookmarking tools actually don't mind the spacing

Code:

http://twitter.com/home?status=%title%%20-%20%url%

After some digging I noticed the spacing isn't what's causing it not to work with the vBulletin (default) bookmarking tools.

Ie.

Code:

http://twitter.com/home?status={URL} TRUE
http://twitter.com/home?status={TITLE} TRUE

http://twitter.com/home?status={TITLE}{URL} FALSE (which should work)
http://twitter.com/home?status={TITLE}-{URL} FALSE ("")

http://twitter.com/home?status={TITLE}%20-%20{URL} FALSE

Edit:
It's because Twitter doesn't use 2 different identifiers in its URL

Ie.

Code:

http://www.facebook.com/share.php?u={URL}&t={TITLE}

Also, could you perhaps point me to the file where this is been managed, as I'd like to change the title separator from + to an actual space?

Hello,

vBSEO doesn't replace forum URLs *embedded* in other URLs (like in this case, link pointing to twitter), unless the link is one of parameters included in link (and not just a "substring" of a parameter). This is done to avoid possible issues (corrupting links where replacement is actually should not occur) and for performance reasons.
These "nested" links are handled in functions_vbseo.php file, mainly in this code part:

PHP Code:

if(strstr($dec_v,'http:') && (substr($dec_v,0,strlen($vboptions['bburl2']))==$vboptions['bburl2']))
{
$dec_v = vbseo_replace_urls('', $dec_v);
$v = urlencode($dec_v);
} 


you can try to replace it with:

PHP Code:

if(preg_match('#('.preg_quote($vboptions['bburl2'], '#') . '.*)$#' , $dec_v, $dec_m))
{
$dec_v = str_replace($dec_m[1], vbseo_replace_urls('', $dec_m[1]), $dec_v);
$v = urlencode($dec_v);
} 


Thanks Oleg, I understand, and it works like a charm! I assume it (vBulletin's default social bookmarking) works a bit different than the vBSEO social bookmarking rewrites, as it works instantly there.

Code:

http://twitter.com/home?status=Reading%20%27{TITLE}%27%20{URL}

Again, much appreciated all!