Table Lock Issues

PHP Code:

select count(*) as preposts
from " . vbseo_tbl_prefix('post') . " p
LEFT JOIN " . vbseo_tbl_prefix('deletionlog') . " AS deletionlog ON(deletionlog.primaryid = p.postid AND type = 'post')
where
deletionlog.primaryid IS NULL
AND p.threadid='" . $post['threadid'] . "'
AND p.visible=1
AND p.dateline " . (($bbuserinfo['postorder'] == 0) ? '<=' : '>=') . $post['dateline'] . " 


This seems to cause massive table-locks for long threads.
Make a JOIN on deletionlog seems really pointless here, as p.visible = 1 already selects only those threads that are not deleted, eg. deletionlog.primaryid will alway be NULL here.

vBulletin itself removed has such JOINs in 3.0.X, but they were since removed to avoid such issues.

This is actually a vBulletin issue as the table locks are caused by vBulletin itself. Thats why for big boards it is not advised to allow very long threads

Yes, vBulletin itself has issues with long queries (->sorting by dateline) - but this is not the problem reported here.

Please take a look at the query again - the JOIN is really not needed.

I will investigate this and will check if we can remove this for vBSEO 3.3.1

/* NOTE: This issue has been resolved. The fix will be distributed with the next vBSEO build. */