Problematic vBulletin Version detection

Hey,

Some of DragonByte Tech's customers have reported issues with our products when used in conjunction with vBSEO. After some investigation, it's been determined to be the cause of this function:

PHP Code:

function vbseo_fetch_tpl($tplname)
{
    return class_exists('vB_Template') ? vB_Template::fetch_template_raw($tplname) : fetch_template($tplname);
} 


Our products are made to work with vBulletin 3 and vBulletin 4 and by implementing an "emulated" vB_Template class, our codebases remain the same between the 2 versions to allow seamless updates and very little chance of vB version-specific bugs. Now on a multi-platform product we use vBulletins stock version number to determine what we're running on and it allows the code to work - something which not many modifications do as new modifications aren't made towards vB3 compat aswell as vB4 compat.

Using the following function as a replacement for the above one, however, our customers have reported no problems:

PHP Code:

function vbseo_fetch_tpl($tplname)
{
    global $vbulletin;
    return intval($vbulletin->versionnumber) != 3 ? vB_Template::fetch_template_raw($tplname) : fetch_template($tplname);
} 


Could this please be incorporated into the full release?
Thanks in advance


Fillip
- DragonByte Tech CEO

Hello,

the following will be used in vBSEO to maintain compatibility:

Code:

(class_exists('vB_Template') && method_exists(vB_Template, 'fetch_template_raw')) ? vB_Template::fetch_template_raw($tplname) : fetch_template($tplname);