Problem with: Go to last Post and why did he loads showthread.php two times?

Osbes · #1 07-06-2008, 10:23 PM

You can also reconstruct this error on this site.
To better understand and see the problem, go to
http://www.vbseo.com/usercp/editoptions/
and set for
"Thread Display Mode" the value "Newest First"
(it also works with "Oldest First", but then you need to remenber, which was the last page, you read and if there comes no page after your last page, you need to find a thread, where comes a page after yor last page and this is very boring)

Than go to
http://www.vbseo.com/forums/

And klick on any

, where the thread has more than one page and your last seen post ist not on the first page

So try for example
vBulletin 3.7.2 Released - Page 2 - vBulletin SEO Forums

If you already read this thread, it should send you now to something like
vBulletin 3.7.2 Released
but what happend is, that it send you to (or something else, if the thread changes)
vBulletin 3.7.2 Released

As far as i can say, it appear, that wenn i go to
vBulletin 3.7.2 Released - Page 2 - vBulletin SEO Forums

he loads the showthread.php two times.
The first time, he knows the right pagenumber and the secondtime, he did not.

If you look into the vB code and analys the problem, you will see, that when he calculate $vbulletin->GPC['pagenumber'] the first time, he set
$postorder = DESC an has an $postinfo[dateline] set.
At the second time, he also set $postorder = DESC, but know he has no value for $postinfo[dateline]

So he thinks, that all postings are new and calculate a most totally wrong pagenumber.

And if you look closer yu will see, that there is no $_GET['postid'] at the second time.

Oleg Ignatiuk · #2 07-07-2008, 12:34 AM

Please try to modify functions_vbseo_createurl.php file:
FIND:

PHP Code:

  if (($bbuserinfo['postorder'] == 1) && !$pinfo['prepostsproc'] && isset($pinfo['preposts']) )
{   
$pinfo['preposts'] = $totr - $pinfo['preposts'] + 2;
}

and move it a few lines lower, so that it appear right ABOVE this line:

PHP Code:

  if (isset($pinfo['preposts']) && $page == 1 && !$gotopost)

Osbes · #3 07-07-2008, 06:26 PM

Thanks for the fast Support, works fine for me

Oleg Ignatiuk · #4 07-07-2008, 07:15 PM

You are welcome!

briansol · #5 07-07-2008, 08:53 PM

is this a bug fix that everyone should include?

Oleg Ignatiuk · #6 07-07-2008, 09:22 PM

Yes.

Osbes · #7 07-07-2008, 10:08 PM

Sorry, i just see, that it works now correct for

but i still have the same problem using

So if i want to go to the last unread post, it is perfect, but if i want to go to the last post, he always send me to the last page and ignore the postorder "Newest First", where the last post should be on the first page.

When i think more generell about this, i came up with a new problem, but i think this should be an vBulletin problem:
I think it is difficult, if you want to share links between someone with "Newest First" and "Oldest First", because if you send an Link whitout an postid and only threadid + pagenumber both Users will see other Sites.
So you can't say "Hey dude, look at page 11, awesome posting", or "the solution to your request should be in this thread(whitout postid, only threadid + pagenumber)", when you are not sure, that every user use the same sort rule for postings.

Oleg Ignatiuk · #8 07-07-2008, 10:27 PM

Quote:

So if i want to go to the last unread post, it is perfect, but if i want to go to the last post, he always send me to the last page and ignore the postorder "Newest First", where the last post should be on the first page.

Can you provide an example URL and testing account in support ticket to check that? It works fine for me.

Osbes · #9 07-07-2008, 10:43 PM

I go to http://www.vbseo.com/usercp/editoptions/ and use "Newest First" and than i go to
Announcements & Pre-Sales - vBSEO Announcements at vBSEO.com

And than i look for example at "Sticky: vBSEO 3.2.0 Gold Released!"

Then the icon

has the link vBSEO 3.2.0 Gold Released!

But it should be
vBSEO 3.2.0 Gold Released!

Because i set "Newest First" and so the last post must be on the first page.
But in fact, everytime i see the link for the last page.

Oleg Ignatiuk · #10 07-07-2008, 10:48 PM

Does that happen on your forum as well? (we do not have the fix mentioned above applied here on vbseo.com yet)

Osbes · #11 07-07-2008, 11:53 PM

Yes, you can see the Problem at our Forum as well.
United-Forum

Oleg Ignatiuk · #12 07-08-2008, 01:03 AM

Can you provide an example URL and testing account in support ticket?

Osbes · #13 07-09-2008, 12:27 PM

Sure, there should be an support ticket now.

bernard · #14 08-08-2008, 08:00 AM

Was this fix included in 3.2 Gold?

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Showthread Rewrite Problem	Jens	Deutsch	4	08-13-2007 08:07 AM
showthread problem (urgent)	Notorious	Troubleshooting	4	10-20-2006 08:07 PM
DataBase Errors in random threads - Showthread is the problem - How to resolve?	system0	Troubleshooting	11	05-01-2006 10:00 PM
Post times	macooper	Pre-Sales Questions	2	09-24-2005 06:49 PM

SEO

Problem with: Go to last Post and why did he loads showthread.php two times?

Problem with: Go to last Post and why did he loads showthread.php two times?

Similar Threads