Probable Bug in Google Analytis Code

Has I report the original Bug for vBulletin but it is a vBSEO issue.

See it here
Threaded Mode - vBulletin Community Forum - Projects

Hello,

Please try to modify functions_vbseo.php file:
FIND:

PHP Code:

if($tmode=='threaded') 


REPLACE WITH:

PHP Code:

if($tmode=='threaded'||$tmode==1) 


Tried, but don't fix

The Java Script Error

'curpostid' not defined

Could you please open a ticket with FTP access and testing forum account for troubleshooting?

To get it work the Code should be:

FIND:

PHP Code:

if($tmode=='threaded') 


REPLACE WITH:

PHP Code:

if($tmode='threaded'||$tmode=1) 


Thanks for posting.
Btw, I won't be affected, as I have disabled the hybrid/threaded views.

@ Threaded Mode - vBulletin Community Forum - Projects

You will need to harass their developers, or disable the plugin (I don't know which one; wild guess says is certain "SEO" addon) to correct this issue.

LOL.

Heh
I think that he was only ironic (maybe!)

Originally Posted by Sysop

To get it work the Code should be:

FIND:

PHP Code:

if($tmode=='threaded') 


REPLACE WITH:

PHP Code:

if($tmode='threaded'||$tmode=1) 


are you sure?

that's not exactly a logical statement.

= is an assignment
== is a comparison

Originally Posted by briansol

are you sure?

that's not exactly a logical statement.

= is an assignment
== is a comparison

it works in that mode for me
if I use == comparison
I get the result how I do nothing

if($tmode='threaded'||$tmode=1)

ASSIGNS $tmode to 'threaded', and then to 1
thus the 'if' will always be true

The same result is if using

PHP Code:

if($tmode=='threaded'||$tmode=1) 


combined comparison and assignment to $tmode variable, and I think this is better then above solution that I have posted

Again, that's not really logical.

because you are effectively DEFINEING $tmode, it will ALWAYS be true.

what you have is the same as

if(1)

1 certainly exists.

What you say is probable true, but in that way it works.

Right, it will work for threaded view.

but, are you breaking linear mode because of it?