Custom 404 Not Being Used

Hi,

Current behavior: When the FORUM URL format (and probably other formats too, please check) catches non-existent files in a directory, vbseo.php throws an invalid forum error if the URL doesn't resolve to a forum.

This is sometimes unwanted behavior, especially when the format is generic: /root/[forum-title]/

We may have set our own rewrite rules for certain pages, where we want /[forum-title]/ to resolve to a forum, but /[custom-page]/ to resolve to custom page, or at least want a non-existent URL to resolve to a 404.

It is not possible to bypass this with Custom Rewrite Rules in the AdminCP since these aren't checked until other URLs have already made the false positive.

This can be fixed in vbseo.php by finding:

Code:

else
if (isset($vbseo_arr['forum_id']))

And replacing it with:

Code:

else
if (intval($vbseo_arr['forum_id']))

This fix would potentially remove invalid ID messages entirely, but I think it is better to have a slightly inaccurate error message, than not to be able to serve our own URLs. If we absolutely must have invalid ID messages, then I think they should only occur if the format was not generic (i.e. included the [forum_id]).

Keep in mind that this probably applies to other URLs than just forum URLs, depending if the format only matches titles and is in the same directory as a custom page.

The generic "Invalid forum specificed" error comes from vb, not vbseo. I do like this idea though, and will flag it for the developers to look at in more detail.

Yes, I'm aware the error comes from vBulletin, but would not have done so if vBSEO didn't pass the invalid request. Hence my point, not to pass invalid requests when the ID is invalid - vBSEO knows this before passing it off to vBulletin.