'Cleanup HTML Code' feature removes </pre> from bbcode_code template

When I enable the 'Cleanup HTML Code' feature in vBSEO (I use the current version), about 30 pages on my forum no longer validate. In all of these pages a poster used the 'Code' bbcode. W3 validator points at a missing </pre> tag.

When I disable the 'Cleanup HTML Code' feature, I can see the </pre> tag present in my source.

I never used the 'Cleanup HTML Code' feature before, so I do not know if this is a new issue in the latest vbSEO version.

Please advise. I'm leaving the 'Cleanup HTML Code' feature disabled in the meantime.

Thanks.

Hello ,

vBSEO clean up feature only removes white spaces and comments within your pages. Enabling it or disabling should not effect page validation at all.

Hi Mert,

Yes, I understand the feature is supposed to remove only empty lines and comments. That's the reason I posted it here to the bug section.

I just tested it the second time, but I'm getting the same results. :(

My entire site validates with no markup errors when the 'HTML Cleanup' feature is not used. But when I enable the feature, all pages that contain the code bbcode, no longer pass the w3 validation.

Here's a sample snippet of source code from one of such pages.

'HTML Cleanup' OFF

Code:

        <!-- message -->
        <div id="post_message_663">
            
            Marvin<br />
 <br />
I tried adding this code to let the Scanner detect which S&amp;T is running between 2008 and 2006-2007. It didn't work. Can you suggest an alteration to the code? I have two S&amp;T installed on my computer and would like the POI to be the same for 2006 to 2008. It would be nice to have to avoid using two versions. <br />
 <br />
 <br />
<div style="margin:20px; margin-top:5px">
    <div class="smallfont" style="margin-bottom:2px">Code:</div>
    <pre class="alt2" dir="ltr" style="
        margin: 0px;
        padding: 6px;
        border: 1px inset;
        width: 640px;
        height: 114px;
        text-align: left;
        overflow: auto">If WinExists(&quot;AfxWnd802&quot;) Then
    $pos_AfxWnd802 = ControlGetPos($productname, &quot;&quot;, &quot;AfxWnd802&quot;)
EndIf    
If WinExists(&quot;AfxWnd702&quot;) Then    
    $pos_AfxWnd802 = ControlGetPos($productname, &quot;&quot;, &quot;AfxWnd702&quot;)
EndIf</pre>
</div>
        </div>
        <!-- / message -->

'HTML Cleanup' ON

Code:

<div id="post_message_663">
            
            Marvin<br /> <br />
I tried adding this code to let the Scanner detect which S&amp;T is running between 2008 and 2006-2007. It didn't work. Can you suggest an alteration to the code? I have two S&amp;T installed on my computer and would like the POI to be the same for 2006 to 2008. It would be nice to have to avoid using two versions. <br /> <br /> <br /> <div style="margin:20px; margin-top:5px"> <div class="smallfont" style="margin-bottom:2px">Code:</div> <pre class="alt2" dir="ltr" style="
        margin: 0px;
        padding: 6px;
        border: 1px inset;
        width: 640px;
        height: 114px;
        text-align: left;
        overflow: auto">If WinExists(&quot;AfxWnd802&quot;) Then
    $pos_AfxWnd802 = ControlGetPos($productname, &quot;&quot;, &quot;AfxWnd802&quot;)
EndIf    
If WinExists(&quot;AfxWnd702&quot;) Then    
    $pos_AfxWnd802 = ControlGetPos($productname, &quot;&quot;, &quot;AfxWnd702&quot;)
EndIf
</div> </div>

W3 Validator reports: end tag for "pre" omitted, but OMITTAG NO was specified

Originally Posted by Mert Gökçeimam

vBSEO clean up feature only removes white spaces

The <pre> element preserves white spaces. I'm thinking there may be some relationship there.

P.S. The issue is also present here on vbseo.com: W3 Validation of this page - try to disable html cleanup, and the markup errors related to the <pre> element should go away.

similar thread:
optimize html text - problem mediawiki - preformatted text

looks like there may be an issue with the preg replace.

Brian, thanks for looking into it. Yes, that touches the same issue. It may be worth looking into it deeper, as vbseo.com forum is affected by it, too: W3 Validation of this page - try to disable the html cleanup, and the markup errors related to the <pre> element should go away.

The HTML Cleanup feature removes the </pre> closing tag for some reason. As a temporary work-around I added a second </pre> closing tag to bbcode_code template, as shown in the code bellow.

Code:

overflow: auto">$code</pre></pre>

One of the two </pre> closing tags is removed by the HTML Cleanup feature, but the other one is not removed. Now my pages pass the W3 HTML validation when HTML Cleanup is enabled.

P.S. I just ran an automated scan of my entire site (after this 'work-around'). All markup errors are gone.

Hello,

please try to modify functions_vbseo.php file:
find:

Code:

array(  '#(<pre[^>]*?>)(.*?)</pre>#sie',

replace with:

Code:

array(  '#(<pre[^>]*?>)(.*?)(</pre>)#sie',

Hi Oleg,

That did it. Thanks so very much!

I modified the functions_vbseo.php file, then I removed my temporary work-around by reverting the bbcode-code template, and now I do see the </pre> closing tag in my source code, and the affected pages do pass the W3 HTML Validator. I scanned my entire site for html markup errors, and none were found.

I double checked that the HTML Cleanup feature was enabled. It was.

I'm a happy camper now!

will functions_vbseo.php be corrected like this in the next update, too?

Yes, this fix wills ship with our next release.

As far as I can see, the last replacement should also be

'<br />',

instead of

"\n",

Since the intended effect is to restore line breaks in code/html/php tags