vBulletin 4.x Base Tag Missing in HTTPS forum

[thincom2000]

I recently added an SSL cert to my forum and changed all the URLs to include the https:// protocol. However, since making this change, vBSEO keeps removing the base tags in my pages, so no relative links or images resolve properly:

I fixed the problem after removing the following from vbseo/vbseo_functions_vb.php:

if(defined('VBSEO_PREPROCESSED') || vbseo_is_https())
$headinclude = preg_replace('#<base href[^>]*?>(\s*?<!--\[if IE\]><\/base><!\[endif\]-->)?#is', '', $headinclude);

Note the vbseo_is_https() call is what causes the issue, because the base tag is removed and never put back... I assume that vBSEO no longer adds the base tag in vBulletin 4 since it is always present in stock vB4 now, but this line was never updated to be consistent with the change.

[Brian Cummiskey]

Did you update the vboptions -> site url to the https version? that's where vbseo gets its base url from.

[thincom2000]

Yes I did. All of our settings use https. Like I said above, the problem is that it removes the tag from the output on that line for some reason, and never re-adds it. After this the browser doesn't get the tag at all.

[Brian Cummiskey]

I flagged this for a developer to review.

[Oleg Ignatiuk]

Hello,

you can replace that line with:

if(defined('VBSEO_PREPROCESSED') || (vbseo_is_https() && !strstr($GLOBALS['vbulletin']->options['bburl'], 'https:')))