2nd Attempt: Retrieving Titles from external Lnks

Hi there,

I already started a thread in the German forums, but I actually do not have the impression as if there is something doing - right now or in near future. At least I'm waiting for 9 days now for a reply. So I try here again.

Let's assume there is a topic with a link. The author wants to show the link as the URL. Like in this example:

Code:

Hey, look at the link to German Google! www.google.de

Well, without vBSEO, vBulletin makes out of this:

Code:

Hey, look at the link to German Google! [url=http://www.google.de]www.google.de[/url]

And this is also right that what the author wanted to show. The URL is clickable and its description is the URL.

Now with vBSEO it's a little bit annoying that the software *always* tries to retrieve the title, even on editing. That means, if you write your post and uncheck "Automatically retrieve titles from external links", everything is great. Until you want to edit again - clicking edit-button and vBSEO retrieves the title - and nobody could prevent it.
So this setting should be saved per-post.

The second annoying thing on this is the "workaround" for the problem above. I mean, if a clever author notices this behavoir, he would say "okay... So give him the URL as a description" and types:

Code:

Hey, look at the link to German Google! [url=http://www.google.de]www.google.de[/url]

But doing this is not a good idea as the software retrieves the title anyway. And HERE I do have a question. Is here on vbseo.com another version running? Because here this does not happen!
www.google.de
Google
(only the second link should be rewritten)

And all good things make three
vBSEO should not follow (known) links with activation IDs in their URL. Because doing so will activate a user as activation links are usually made by adress-lines.


Thanks,
hope for a better support here,

best regards
rellek

Hello,

Now with vBSEO it's a little bit annoying that the software *always* tries to retrieve the title, even on editing.

You can disable "Extract external link titles" option in vBSEO CP or make it working ONLY when "Extract titles" checkbox is enabled by modifying functions_vbseo_hook.php file:
FIND:

PHP Code:

(!isset($_POST['vbseo_is_retrtitle']) || isset($_POST['vbseo_retrtitle'])) 


REPLACE WITH:

PHP Code:

(isset($_POST['vbseo_is_retrtitle']) && isset($_POST['vbseo_retrtitle'])) 


But doing this is not a good idea as the software retrieves the title anyway. And HERE I do have a question. Is here on vbseo.com another version running? Because here this does not happen!

Please provide us with testing account access on your forum to confirm this issue. The title should be only retrieved when in-url text is identical to the URL:

Code:

Hey, look at the link to German Google! Google

vBSEO should not follow (known) links with activation IDs in their URL. Because doing so will activate a user as activation links are usually made by adress-lines.

What do you mean by "activation links"?

Thanks for your reply

My forums are here:
rellek[org] | your home on the www - Startseite
You may use this forum:
Test- und Spam-Forum - rellek[org]
username is: testuser
password: test4vbseo

After the code modification the problem with automatically retrieving titles on edit is solved, thank you
But the problem with the link-description as the URL still remains.

Because of activation links... You know, when you register somewhere and the software wants to check if your email-address really exists, they send you a mail with a link you must click. And vBSEO clicks it in order to retrieve the title of that page - which activates the user.

I just tried to post the code you posted above on your forum and it didn't retrieve the link, the same as here on vbseo.com:
link - rellek[org]

Did you use the quick reply?

Because with the usual reply it's just like before.

That's maybe because of your code modification I applied in. But with the normal reply form the option to retrieve is set. And then my sample post from above makes the "wrong" appearance:
link - rellek[org]

Please also try to change this:

PHP Code:

if ($ul && !@strstr($ul, $ulin)) 


to:

PHP Code:

if ($ul && !@strstr($ulin, $ul)) 


Great! Thank you a lot! Working fine now :-)

Great!