vBulletin SEO Forums

SEO

vBulletin Search Engine Optimization

Buy vBSEO Now! HACKER SAFE certified sites prevent over 99.9% of hacker crime.
ne nw
New vBSEO Discount Level for Network Builders Meet vBSEO Team in New York (Nov. 3rd & 4th) vBSEO 3.2.0 GOLD Has Landed Success with vBSEO = 600ore Web Visitors + $1400 in a Day! Crawlability Inc. Files for SEO Technology Patent
se sw

validation and a few other things

This is a discussion on validation and a few other things within the Template Modifications forums, part of the vBulletin SEO Discussion category; Okay yesterday I had over 400+ validation errors today I have 8 left after fixing all the ones I can. ...

Go Back   vBulletin SEO Forums > vBulletin SEO Discussion > Template Modifications

Enhancing 80 million pages.

Register FAQ Members List Social Groups Calendar Search Today's Posts Mark Forums Read
  #1  
Old 08-08-2007, 01:21 AM
Senior Member
Big Board Administrator
 
Real Name: Matt
Join Date: May 2006
Posts: 561
validation and a few other things

Okay yesterday I had over 400+ validation errors today I have 8 left after fixing all the ones I can.

Can you have a look and see if you can work these ones out:
[Invalid] Markup Validation of http://www.gamerzneeds.net/forums/ - W3C Markup Validator


also I think I have a missing table tag or something wrong here, because my skin looks good when logged in, but when logged out I have a problem like a missing table tag:
Code:
<!-- top -->
<table width="100%" border="0" cellspacing="0" cellpadding="0">
  <tr>
    <td width="27"><img src="$stylevar[imgdir_misc]/forumtitle_left.gif" width="27" height="29" alt="" /></td>
    <td class="tcat" style="background: url($stylevar[imgdir_misc]/forumtitle_bg.gif) top left repeat-x;">
    <a rel="nofollow" href="forumdisplay.php?$session[sessionurl]f=$forum[forumid]">$forum[title]</a>    </td>
    <td width="36">
    <if condition="$childforumbits"><a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('forumbit_$forumid')"><img id="collapseimg_forumbit_$forumid" src="$stylevar[imgdir_misc]/forumtitle_right{$collapseimg_forumid}.gif" alt="" border="0" /></a>
</if>    
</td>
</tr>
</table>


<!-- /top -->




<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="$stylevar[outertablewidth]" align="center">
<if condition="$childforumbits">
<tbody id="collapseobj_forumbit_$forumid" style="{$collapseobj_forumid}">
    <tr align="center">
      <td class="thead" width="6%">&nbsp;</td>
      <td class="thead" width="52%" align="$stylevar[left]">$vbphrase[forum]</td>
      <td class="thead" width="30%">$vbphrase[last_post]</td>
      <td class="thead" width="6%">$vbphrase[threads]</td>
      <td class="thead" width="6%">$vbphrase[posts]</td>
      <if condition="$vboptions[showmoderatorcolumn]">
      <td class="thead">$vbphrase[moderator]</td>
      </if>
    </tr>
$childforumbits
</if>
</tbody>
</table>
See if you can find anything wrong, because I cant seem to see it as i'm still learning.

Thanks for any help, really appreciate it

Last edited by hornstar6969; 08-09-2007 at 05:07 AM.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2  
Old 08-09-2007, 03:46 AM
Senior Member
 
Real Name: Justin
Join Date: Jul 2006
Posts: 231
I'm not an expert either but I think at the bottom, you have an if condition and you closed it in 2 place, both too early. So remove the 2 </if> and put 1 under </tbody> (the very last line).

I'm not sure if that will fix the problem.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3  
Old 08-09-2007, 04:53 AM
Senior Member
Big Board Administrator
 
Real Name: Matt
Join Date: May 2006
Posts: 561
Quote:
Originally Posted by jbartle View Post
I'm not an expert either but I think at the bottom, you have an if condition and you closed it in 2 place, both too early. So remove the 2 </if> and put 1 under </tbody> (the very last line).

I'm not sure if that will fix the problem.
doing that, would not even let me save the template. I tried placing it in a few different places, but that didnt fix it, so i've moved it back to where it was for now.

Any other ideas anyone?
The problem may not even be in that template, that is just my feeling, it could be in forumhome template, if you have a look at my validation errors in the link above, maybe you will have an idea.

Thanks.

Last edited by hornstar6969; 08-09-2007 at 06:01 AM.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4  
Old 08-10-2007, 09:55 AM
Senior Member
 
Real Name: Justin
Join Date: Jul 2006
Posts: 231
Well...if you are logged out and it doesn't look good...I would think that an if condition is interfering with your code. I would look to find an if condition for members to see if it accidentally is enclosing another tag.

What template is that for. Your forumhome? What modifications have you made to it?
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #5  
Old 08-11-2007, 04:15 PM
briansol's Avatar
Senior Member
vBSEO Pre-Release TeamDesign for SEOBig Board Administrator
 
Real Name: Brian
Join Date: Apr 2006
Location: Central CT, USA
Posts: 5,449
who ever did your template should be banned from coding.

<div class="alt1" style="float: left; width: 110px; position: absolute; margin-left: 119px;">

lol
you can't float an abs positioned div... and apply margins to it does nothing.

wtf?


and there's 213123122 other example of this.

i'd seriously just start over with some new code. validating this isn't going to get youanywhere.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #6  
Old 08-12-2007, 02:37 AM
Senior Member
Big Board Administrator
 
Real Name: Matt
Join Date: May 2006
Posts: 561
Quote:
Originally Posted by briansol View Post
who ever did your template should be banned from coding.

<div class="alt1" style="float: left; width: 110px; position: absolute; margin-left: 119px;">

lol
you can't float an abs positioned div... and apply margins to it does nothing.

wtf?


and there's 213123122 other example of this.

i'd seriously just start over with some new code. validating this isn't going to get youanywhere.
the only template this shows in: <div class="alt1" style="float: left; width: 110px; position: absolute; margin-left: 119px;">

is the inferno_shoutbox_box template

Do you know what I should change in this template:

Code:
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<thead>
<tr>
    <td class="tcat" align="center">
        <a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('forumhome_infernoshout')"><img id="collapseimg_forumhome_infernoshout" src="$stylevar[imgdir_button]/collapse_tcat$vbcollapse[collapseimg_infernoshout].gif" alt="" border="0" /></a>
        <a href="infernoshout.php?{$session['sessionurl']}do=archive">Shoutbox</a>
    </td>
</tr>
</thead>
<tbody id="shoutbox_editshout" style="display: none;">
    <tr>
        <td class="alt1" align="left" width="100%">
            <form onsubmit="return InfernoShoutbox.do_edit_shout();" action="index.php" id="editshoutform">
                <span style="float: right;">
                    <input type="submit" class="button" value="Update" />
                    <input type="button" class="button" value="Delete" onclick="InfernoShoutbox.do_edit_shout(true);" />
                    <input type="button" class="button" value="Cancel" onclick="InfernoShoutbox.cancel_edit_shout();" />
                </span>
                <input type="text" size="60" class="bginput" name="editshout" />
                <input type="hidden" name="shoutid" value="" />
            </form>
        </td>
    </tr>
</tbody>
<tbody id="shoutbox_smilies" style="display: none;">
    <tr>
        <td class="alt1" align="center" width="100%" id="shoutbox_smilies_row">
        </td>
    </tr>
</tbody>
<tbody id="collapseobj_forumhome_infernoshout" style="$vbcollapse[collapseobj_forumhome_infernoshout]">
    <tr>
        <td class="alt1" align="left" width="100%">
        <if condition="!$vboptions[ishout_editor_position] && $bbuserinfo[userid] > 0">
            <form onsubmit="return InfernoShoutbox.shout();" action="index.php">
            {$infernoshout->editor}
            <div style="height: 4px"></div>
            </form>
        </if>
        <table cellpadding="0" cellspacing="0" border="0" width="100%">
        <tr>
        <td class="alt2" style="width: 100%; padding: 0px;" align="left">
            <div class="alt1" style="float: left;">
                <span class="alt2" style="display: block;">
                <span class="alt1" style="width: 3px; height: 1px; display: block; overflow: hidden;"></span>
                <span class="alt1" style="width: 2px; height: 1px; display: block; overflow: hidden;"></span>
                <span class="alt1" style="width: 1px; height: 1px; display: block; overflow: hidden;"></span>
                </span>
            </div>
            <div class="alt1" style="float: right;">
                <span class="alt2" style="width: 1px; height: 1px; display: block; overflow: hidden;"></span>
                <span class="alt2" style="width: 2px; height: 1px; display: block; overflow: hidden;"></span>
                <span class="alt2" style="width: 3px; height: 1px; display: block; overflow: hidden;"></span>
            </div>

        <div class="alt2" style="padding: 0px;">
                <div class="alt1" style="float: left; width: 110px; position: absolute; margin-left: 6px;">
                    <div class="smallfont" style="text-align: center;"><a href="?" onclick="return InfernoShoutbox.show('shoutbox');">Shoutbox</a></div>
                    <div class="alt1">
                        <span style="float: right;">
                            <span class="alt2" style="display: block;">
                            <span class="alt1" style="width: 3px; height: 1px; display: block; overflow: hidden;"></span>
                            <span class="alt1" style="width: 2px; height: 1px; display: block; overflow: hidden;"></span>
                            <span class="alt1" style="width: 1px; height: 1px; display: block; overflow: hidden;"></span>
                            </span>
                        </span>
                        <span class="alt2" style="width: 1px; height: 1px; display: block; overflow: hidden;"></span>
                        <span class="alt2" style="width: 2px; height: 1px; display: block; overflow: hidden;"></span>
                        <span class="alt2" style="width: 3px; height: 1px; display: block; overflow: hidden;"></span>
                    </div>
                </div>
                <div class="alt1" style="float: left; width: 110px; position: absolute; margin-left: 119px;">
                    <div class="smallfont" style="text-align: center;"><a href="?" onclick="return InfernoShoutbox.show('activeusers');">Active Users</a>: <span id="shoutbox_activity">0</span></div>
                    <div class="alt1">
                        <span style="float: right;">
                            <span class="alt2" style="display: block;">
                            <span class="alt1" style="width: 3px; height: 1px; display: block; overflow: hidden;"></span>
                            <span class="alt1" style="width: 2px; height: 1px; display: block; overflow: hidden;"></span>
                            <span class="alt1" style="width: 1px; height: 1px; display: block; overflow: hidden;"></span>
                            </span>
                        </span>
                        <span class="alt2" style="width: 1px; height: 1px; display: block; overflow: hidden;"></span>
                        <span class="alt2" style="width: 2px; height: 1px; display: block; overflow: hidden;"></span>
                        <span class="alt2" style="width: 3px; height: 1px; display: block; overflow: hidden;"></span>
                    </div>
                </div>
                <div class="alt1" style="float: left; width: 110px; position: absolute; margin-left: 232px; display: none;" id="shoutbox_loader">
                    <div class="smallfont" style="text-align: center;"><img src="infernoshout/images/processing.gif" alt="" /></div>
                    <div class="alt1">
                        <span style="float: right;">
                            <span class="alt2" style="display: block;">
                            <span class="alt1" style="width: 3px; height: 1px; display: block; overflow: hidden;"></span>
                            <span class="alt1" style="width: 2px; height: 1px; display: block; overflow: hidden;"></span>
                            <span class="alt1" style="width: 1px; height: 1px; display: block; overflow: hidden;"></span>
                            </span>
                        </span>
                        <span class="alt2" style="width: 1px; height: 1px; display: block; overflow: hidden;"></span>
                        <span class="alt2" style="width: 2px; height: 1px; display: block; overflow: hidden;"></span>
                        <span class="alt2" style="width: 3px; height: 1px; display: block; overflow: hidden;"></span>
                    </div>
                </div>
                <div class="alt1" style="float: left; width: 250px; position: absolute; margin-left: 345px; display: none;" id="shoutbox_notice">
                    <div class="smallfont" style="text-align: left; padding-left: 3px;" id="shoutbox_notice_message"></div>
                    <div class="alt1">
                        <span style="float: right;">
                            <span class="alt2" style="display: block;">
                            <span class="alt1" style="width: 3px; height: 1px; display: block; overflow: hidden;"></span>
                            <span class="alt1" style="width: 2px; height: 1px; display: block; overflow: hidden;"></span>
                            <span class="alt1" style="width: 1px; height: 1px; display: block; overflow: hidden;"></span>
                            </span>
                        </span>
                        <span class="alt2" style="width: 1px; height: 1px; display: block; overflow: hidden;"></span>
                        <span class="alt2" style="width: 2px; height: 1px; display: block; overflow: hidden;"></span>
                        <span class="alt2" style="width: 3px; height: 1px; display: block; overflow: hidden;"></span>
                    </div>
                </div>
        </div>
        </td>
        </tr>
        </table>
        <div class="alt2"><span id="shoutbox_frame" style="display: block; padding: 3px; padding-top: 16px;overflow:auto;height:{$vboptions['ishout_height']}px; width: 99%;">Loading...</span><span id="shoutbox_users_frame" style="display: none; padding: 3px; padding-top: 16px;overflow:auto;height:{$vboptions['ishout_height']}px; width: 99%;">Loading...</span></div>
        <div class="alt2">
            <span style="float: right;">
                <span class="alt1" style="display: block;">
                <span class="alt2" style="width: 3px; height: 1px; display: block; overflow: hidden;"></span>
                <span class="alt2" style="width: 2px; height: 1px; display: block; overflow: hidden;"></span>
                <span class="alt2" style="width: 1px; height: 1px; display: block; overflow: hidden;"></span>
                </span>
            </span>
            <span class="alt1" style="width: 1px; height: 1px; display: block; overflow: hidden;"></span>
            <span class="alt1" style="width: 2px; height: 1px; display: block; overflow: hidden;"></span>
            <span class="alt1" style="width: 3px; height: 1px; display: block; overflow: hidden;"></span>
        </div>
        <if condition="$vboptions[ishout_editor_position] && $bbuserinfo[userid] > 0">
            <form onsubmit="return InfernoShoutbox.shout();" action="index.php">
            <div style="height: 2px"></div>
            {$infernoshout->editor}
            </form>
        </if>
        </td>
    </tr>
</tbody>
</table>
<br />
<script type="text/javascript" src="infernoshout/browser/infernoshout.js?ver=1.0.1"></script>
<script type="text/javascript">
<!--

/**
 * Inferno Shoutbox Javascript Engine
 * Created By Inferno Technologies
 * All Rights Reserved
 * * * * * * * * * * * * * * *
 */

InfernoShoutbox = new _ishout;
InfernoShoutbox.initiate('{$infernoshout->script}', '{$infernoshout->vbulletin->options['ishout_idletime']}', '{$infernoshout->editor_settings['s_bold']}', '{$infernoshout->editor_settings['s_italic']}', '{$infernoshout->editor_settings['s_underline']}', '{$infernoshout->vbulletin->options['ishout_shoutorder']}', '{$infernoshout->vbulletin->options['ishout_flood']}');
-->
</script>
Thanks.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #7  
Old 08-14-2007, 12:27 AM
briansol's Avatar
Senior Member
vBSEO Pre-Release TeamDesign for SEOBig Board Administrator
 
Real Name: Brian
Join Date: Apr 2006
Location: Central CT, USA
Posts: 5,449
yeah, i'm not even going to attempt that dude... lol

there is so much wrong and so much useless markup...

IMO, ditch the program.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads

Thread Thread Starter Forum Replies Last Post
W3 Validation gedsta Template Modifications 1 04-04-2007 05:41 PM
Problem with XHTML validation Get Shorty Troubleshooting 5 01-11-2007 12:07 AM
New Skin Validation Challenges LPH2005 Template Modifications 8 11-06-2006 12:16 AM
XHTML Validation error Griffin Troubleshooting 3 08-05-2006 01:54 AM


All times are GMT -4. The time now is 01:07 PM.


Powered by vBulletin Version 3.8.0 Beta 3
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.5 ©2008, Crawlability, Inc.