Google not indexing the right sites

It's been over a week and a half now that I've installed vbSEO and yet google is still indexing old/wrong URLs. I disabled the archive a few days ago and not a single of the URLs that google has updated is one of the new ones. What am I doing wrong?

site:mpcdownloads.com vbseo - Google Search

My website is MPC Download Center . What I have noticed though, is that it's also indexing sites that don't exist for instance on this forum when I posted about how the URLs would be changed, it put both of those URLs into the index even though both are 404's.

Originally Posted by NightNinja

What am I doing wrong?

The only thing you're doing wrong is that you're eager. It can take quite a while for updates to show up. (Months, even.) So, just hang in there.

Ok, but I seriously think there are still problems since the a lot of the links were changed in their format and still work and don't redirect to the new URLs.

Example: download travis minimizer - Google Search

Google provides a link to the old URL which (if clicked on) still goes to the old URL which still works. This is because in order to properly install vbSEO I had to change the link to ad &name= &cat= in order for it to have the keywords in there properly. I really think that in order for google not to think it's duplicate content I have to somehow make sure the old URLs redirect to the new ones...

Hello,

sure you can define the custom rewrite rules in .htaccess to redirect these URLs.

And how would I do that? I can't manually add 4000+ URLs...

For the automatic redirection, you should add the corresponding code to your downloads.php script.

When you say 'site', you really mean 'page', right?

Originally Posted by Oleg Ignatiuk

For the automatic redirection, you should add the corresponding code to your downloads.php script.

I don't know what you mean by this, how would i go about this?

Originally Posted by kall

When you say 'site', you really mean 'page', right?

Yes i mean pages.

Hello,

The code to insert depends on the specific script you are using, I checked this for you though (vBdownloads and vB3.0.x in your case).

I assume that you want to perform the following redirections (from old-formatted URLs to new URLs with titles included):

Code:

downloads.php?do=cat&id=XX => downloads.php?do=cat&id=XX&catname=YY
downloads.php?do=file&id=XX => downloads.php?do=filet&id=XX&filename=YY&catname=ZZ

You can try the following modification of downloads.php file.

FIND:

PHP Code:

require_once('./includes/dl_panel.php'); # The Panel Info 


ADD BELOW:

PHP Code:

switch ($_GET['do']) {
    case 'cat':
        if(!isset($_GET['catname']))
        {
            standard_redirect('', 'downloads.php?do=cat&id='.$_GET['id'].'&catname='.
                urlencode($DB_site->query_result("SELECT name FROM " . TABLE_PREFIX . "file_cats WHERE id = '".$_GET['id']."'")));
        }

        break;
    case 'file':
        if(!isset($_GET['filename']))
        {
            $res = $DB_site->query("SELECT catid,name FROM " . TABLE_PREFIX . "file_files WHERE id = '".$_GET['id']."'");
            $frow = $DB_site->fetch_array($res);

            standard_redirect('', 'downloads.php?do=file&id='.$_GET['id'].
                '&filename='.urlencode($frow['name']).
                '&catname='.
                urlencode($DB_site->query_result("SELECT name FROM " . TABLE_PREFIX . "file_cats WHERE id = '".$frow['catid']."'"))
                );
        }

        break;
} 


Adding that basically undoes what vbSEO does... It re-adds the old style URLs and vbSEO does not change them.

Please note that I mentioned in the post:

I assume that you want to perform the following redirections (from old-formatted URLs to new URLs with titles included):

Code:

downloads.php?do=cat&id=XX => downloads.php?do=cat&id=XX&catname=YY
downloads.php?do=file&id=XX => downloads.php?do=file&id=XX&filename=YY&catname=ZZ

I see that in your case the redirections are not exactly like this:

Code:

downloads.php?do=cat&id=XX => downloads.php?do=cat&id=XX&name=YY
downloads.php?do=file&id=XX => downloads.php?do=file&id=XX&name=YY&cat=ZZ

So, you should modify the php code accordingly (not exactly as I posted, but so that it suits to your URLs).

In your case the code will be:

PHP Code:

switch ($_GET['do']) {
    case 'cat':
        if(!isset($_GET['name']) && !isset($_GET['page']))
        {
            standard_redirect('', 'downloads.php?do=cat&id='.$_GET['id'].'&name='.
                urlencode(str_replace(' ', '-', $DB_site->query_result("SELECT name FROM " . TABLE_PREFIX . "file_cats WHERE id = '".$_GET['id']."'"))));
        }

        break;
    case 'file':
        if(!isset($_GET['name']) && !isset($_GET['act']))
        {
            $res = $DB_site->query("SELECT catid,name FROM " . TABLE_PREFIX . "file_files WHERE id = '".$_GET['id']."'");
            $frow = $DB_site->fetch_array($res);

            standard_redirect('', 'downloads.php?do=file&id='.$_GET['id'].
                '&name='.urlencode(str_replace(' ', '-', $frow['name'])).
                '&cat='.
                urlencode(str_replace(' ', '-', $DB_site->query_result("SELECT name FROM " . TABLE_PREFIX . "file_cats WHERE id = '".$frow['catid']."'")))
                );
        }

        break;
} 


Thank you for the fix, my mistake for not noticing, in any case, with this fix, while the URLs still say the same and the old ones turn into the new ones, it creates a new problem that doesn't allow users to be able to download the actual file, rather, it just forwards the user back to the same page they attempted to download it from.

I've updated the code in the post above accordingly, please give it a try.

It works perfectly now! Thanks so much Oleg!

You are welcome!