Results 1 to 6 of 6

Update urchin code

This is a discussion on Update urchin code within the vBSEO Features Archive forums, part of the vBulletin Links & Resources category; EDIT: not Urchin, google Analytics Example pulled from my source code: Code: Content Relevant URLs by <a onClick="javascript :urchinTracker ('/outgoing/http_www_crawlability_com_vbseo_');" ...

  1. #1
    Senior Member briansol's Avatar
    Real Name
    Brian
    Join Date
    Apr 2006
    Location
    Central CT, USA
    Posts
    6,981
    Liked
    8 times

    Update urchin code

    EDIT: not Urchin, google Analytics


    Example pulled from my source code:

    Code:
    Content Relevant URLs by <a onClick="javascript:urchinTracker ('/outgoing/http_www_crawlability_com_vbseo_');" rel="nofollow" href="http://www.crawlability.com/vbseo/">vBSEO</a>
    Not only does this break XHTML 1.0 compatibility, it is also highly in-accessible.

    Please change to:

    Code:
    Content Relevant URLs by <a onclick="urchinTracker('/outgoing/http_www_crawlability_com_vbseo_');" rel="nofollow" href="http://www.crawlability.com/vbseo/">vBSEO</a>
    This will fix the XHTML, and will make the onclick event accesible for non-js people, and still prevent double windows/links in js enabled browsers.
    Last edited by briansol; 06-02-2006 at 05:45 PM.

  2. #2
    vBSEO Staff Oleg Ignatiuk's Avatar
    Real Name
    Oleg Ignatiuk
    Join Date
    Jun 2005
    Location
    Belarus
    Posts
    25,689
    Liked
    157 times
    Hello Brian,

    the lowecase "onclick" was already implemented, I will remove "javascript:" as well.
    Thanks!
    Oleg Ignatiuk / Crawlability Inc.
    vBSEO 3.6.0 GOLD Released!
    Unveiling the NEW vBSEO Sitemap Generator 3.0. - available NOW for vBSEO Customers!


  3. #3
    Senior Member briansol's Avatar
    Real Name
    Brian
    Join Date
    Apr 2006
    Location
    Central CT, USA
    Posts
    6,981
    Liked
    8 times
    and don't forget the return false; too This will prevent the double page load effect.

    Edit: ignore :P
    Last edited by briansol; 06-02-2006 at 05:45 PM.

  4. #4
    vBSEO Staff Oleg Ignatiuk's Avatar
    Real Name
    Oleg Ignatiuk
    Join Date
    Jun 2005
    Location
    Belarus
    Posts
    25,689
    Liked
    157 times
    Hm.. but I think that link will not be opened when false is returned by onclick handler?
    Oleg Ignatiuk / Crawlability Inc.
    vBSEO 3.6.0 GOLD Released!
    Unveiling the NEW vBSEO Sitemap Generator 3.0. - available NOW for vBSEO Customers!


  5. #5
    Senior Member briansol's Avatar
    Real Name
    Brian
    Join Date
    Apr 2006
    Location
    Central CT, USA
    Posts
    6,981
    Liked
    8 times
    ah, you're right. The urchin call doesn't actually GO anywhere, so it still needs to hit the href, yes. Edited my post above.

  6. #6
    vBSEO Staff Oleg Ignatiuk's Avatar
    Real Name
    Oleg Ignatiuk
    Join Date
    Jun 2005
    Location
    Belarus
    Posts
    25,689
    Liked
    157 times
    Ok
    Oleg Ignatiuk / Crawlability Inc.
    vBSEO 3.6.0 GOLD Released!
    Unveiling the NEW vBSEO Sitemap Generator 3.0. - available NOW for vBSEO Customers!


Similar Threads

  1. vBSEO 2.4.0 Released - Includes Google AdSense Targeting Feature!
    By Juan Muriente in forum vBSEO Announcements
    Replies: 74
    Last Post: 05-20-2006, 10:29 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •